Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing macOS tray #2936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing macOS tray #2936

wants to merge 1 commit into from

Conversation

easydigi
Copy link

Fixing macOS tray

package.json
.gitignore
.gitignore
package.json
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these changes seem either irrelevant (*.log) or wrong (package.json, .gitignore).

} else {
window.show();
window.focus();
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent seems to be wrong here.

@@ -82,6 +83,7 @@
"turndown": "7.1.1",
"unescape": "1.0.1",
"ws": "8.8.0",
"xml2js": "^0.4.23",
"yauzl": "2.10.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these extra dependencies added?

},
]);
},
]);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be many whitespace changes which are unnecessary and obscure the real change..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants