Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug in transpose #1949

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fixes bug in transpose #1949

merged 1 commit into from
Jun 4, 2024

Conversation

normanrz
Copy link
Contributor

@normanrz normanrz commented Jun 4, 2024

@zoj613 reported a bug with the transpose codec in zarrita. This PR ports the fix over to zarr-python-

@normanrz normanrz added the V3 Affects the v3 branch label Jun 4, 2024
@normanrz normanrz requested a review from d-v-b June 4, 2024 10:10
@normanrz normanrz self-assigned this Jun 4, 2024
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@normanrz
Copy link
Contributor Author

normanrz commented Jun 4, 2024

Thanks to @brokkoli71 for the fix in zarrita!

@normanrz normanrz merged commit 5c4dc23 into v3 Jun 4, 2024
21 checks passed
d-v-b pushed a commit to d-v-b/zarr-python that referenced this pull request Jun 4, 2024
dcherian added a commit to dcherian/zarr-python that referenced this pull request Jun 25, 2024
* v3: (22 commits)
  [v3] `Buffer` ensure correct subclass based on the `BufferPrototype` argument (zarr-developers#1974)
  Fix doc build (zarr-developers#1987)
  Fix doc build warnings (zarr-developers#1985)
  Automatically generate API reference docs (zarr-developers#1918)
  Update `RemoteStore.__str__` and add UPath tests (zarr-developers#1964)
  [v3] Elevate codec pipeline (zarr-developers#1932)
  0 dim arrays: indexing (zarr-developers#1980)
  `parse_shapelike` allows 0 (zarr-developers#1979)
  Clean up typing and docs for indexing (zarr-developers#1961)
  add json indentation to config (zarr-developers#1952)
  chore: update pre-commit hooks (zarr-developers#1973)
  Bump pypa/gh-action-pypi-publish in the actions group (zarr-developers#1969)
  chore: update pre-commit hooks (zarr-developers#1957)
  Update release.rst (zarr-developers#1960)
  doc: update release notes for 3.0.0.alpha (zarr-developers#1959)
  Basic working FsspecStore (zarr-developers#1785)
  Feature: Top level V3 API (zarr-developers#1884)
  Buffer Prototype Argument (zarr-developers#1910)
  Create issue-metrics.yml
  fixes bug in transpose (zarr-developers#1949)
  ...
@jhamman jhamman deleted the fix-transpose branch October 15, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3 Affects the v3 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants