New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop ignoring these ruff rules #2001

Merged

d-v-b merged 1 commit into zarr-developers:v3 from DimitriPapadopoulos:ignore

Jun 27, 2024

Contributor

DimitriPapadopoulos commented Jun 27, 2024 •

edited

Loading

All issues seem to have been fixed.

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)


Stop ignoring these ruff rules

b2ebb2b

All issues seem to have been fixed.

d-v-b approved these changes

View reviewed changes

Contributor

d-v-b commented Jun 27, 2024

thanks @DimitriPapadopoulos

d-v-b merged commit d6201ac into zarr-developers:v3

18 checks passed

DimitriPapadopoulos deleted the ignore branch

June 27, 2024 18:46

dcherian added a commit to dcherian/zarr-python that referenced this pull request


Merge branch 'v3' into hypothesis-tests

282e5fc

* v3: (22 commits)
  chore: update pre-commit hooks (zarr-developers#2051)
  Apply ruff/flake8-bandit rule B006 (zarr-developers#2049)
  Move fixtures to `tests` (zarr-developers#1813)
  Multiple imports for an import name (zarr-developers#2047)
  Redundant list comprehension (zarr-developers#2048)
  chore: update pre-commit hooks (zarr-developers#2039)
  Cast fill value to array's dtype (zarr-developers#2020)
  chore: update pre-commit hooks (zarr-developers#2017)
  make shardingcodec pickleable  (zarr-developers#2011)
  doc: copy 3.0.0.alpha changelog into release.rst (zarr-developers#2007)
  build(ci): enable python 3.12 in github actions (zarr-developers#2005)
  Bump NumPy to 2.0 (zarr-developers#1983)
  chore: update pre-commit hooks (zarr-developers#1989)
  Fix indexing with bools (zarr-developers#1968)
  Fix string interpolation (zarr-developers#1998)
  Unnecessary comprehension (zarr-developers#1997)
  Stop ignoring these ruff rules (zarr-developers#2001)
  Merge collapsible if statements (zarr-developers#1999)
  Unnecessary comprehension (zarr-developers#1996)
  Handle Path in `make_store_path` (zarr-developers#1992)
  ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment