Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix low contrast in dark theme h3 headings #2003

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

dstansby
Copy link
Contributor

The contrast between text and background is bad for h3 elements:

Screenshot 2024-06-28 at 08 29 26

This is because the colour is manually set in the zarr CSS - removing this fixes the low contrast by making the titles white.

@d-v-b
Copy link
Contributor

d-v-b commented Jun 28, 2024

the change seems reasonable, do we know why the manual adjustment was made?

@dstansby
Copy link
Contributor Author

dstansby commented Jun 28, 2024

It came in this rather large commit: 4dc6f1f. I think it's worth relying on pydata-sphinx-theme to set this to reduce the amount of custom CSS we have to maintain.

@jhamman jhamman added V3 Affects the v3 branch documentation Improvements to the documentation labels Jul 1, 2024
@jhamman jhamman added this to the 3.0.0 milestone Jul 1, 2024
@jhamman jhamman merged commit 5cf2ef1 into zarr-developers:v3 Aug 9, 2024
24 checks passed
@dstansby dstansby deleted the fix-dark-h3 branch August 10, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements to the documentation V3 Affects the v3 branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants