Apply new ruff rules (preview mode) #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2024
Closed
Closed
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
force-pushed
the
ruff_preview
branch
3 times, most recently
from
b8b52ef
to
c5774a5
Compare
F841 Local variable is assigned to but never used This issue is triggered in preview mode.
PYI059 `Generic[]` should always be the last base class This future rule is triggered in preview mode.
RUF021 Parenthesize `a and b` expressions when chaining `and` and `or`
together, to make the precedence clear
This future rule is triggered in preview mode.
RUF022 `__all__` is not sorted This future rule is triggered in preview mode.
DimitriPapadopoulos
force-pushed
the
ruff_preview
branch
from
c5774a5
to
d1f0739
Compare
jhamman
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new rules or issues appear in preview mode (
ruff check --preview).TODO: