Fix Ruby 3.3.0 warnings #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running code that uses the spreadsheet gem with Ruby 3.3.0 causes the following warning to be shown .../gems/spreadsheet-1.3.0/lib/spreadsheet/excel/writer/worksheet.rb:5: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of spreadsheet-1.3.0 to add bigdecimal into its gemspec. This behaviour is documented with the release of Ruby 3.3.0 https://rubyreferences.github.io/rubychanges/3.3.html#gems-that-are-warned-to-become-bundled-in-the-next-version
|
Thank you for the PR! Can you please make sure, that all the tests pass? |
|
yes, that is possible, but they still fail, so we need to fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running code that uses the spreadsheet gem with Ruby 3.3.0 causes the following warning to be shown
.../gems/spreadsheet-1.3.0/lib/spreadsheet/excel/writer/worksheet.rb:5: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of spreadsheet-1.3.0 to add bigdecimal into its gemspec.
This behaviour is documented with the release of Ruby 3.3.0 https://rubyreferences.github.io/rubychanges/3.3.html#gems-that-are-warned-to-become-bundled-in-the-next-version