-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support trilogy
adapter
#815
Comments
Any input on PR #811? |
Oops, I missed that pull request. thanks 👍 |
I'm currently trying to figure out how to properly test this change. The changes I have currently on my PR works as is with a rather large Rails application. When running he mysql test in a Docker container I see the following:
I still need to investigate why the CI is ❌, but I'll try to identify the issue and report back. |
I almost have a 🟢 test running. I discovered a small issue with the Trilogy adapter or composite_primary_keys. Opening a PR against the project to see if I can get that merged. 🤞🏼 I can, after that I can hopefully merge this PR. |
I have opened a PR around add trilogy support here |
@jkowens with my PR merged now can we close this issue? |
Yep 👍 |
A new MySQL adapter (trilogy) has been introduced to rails. rails/rails#47880
activerecord-import should also support trilogy.
I have verified that the application works correctly with the following code.
The text was updated successfully, but these errors were encountered: