This repository has been archived by the owner on Jan 28, 2024. It is now read-only.
Update theme docs #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing in this doc should be considered final until it is merged!
clo4
reviewed
Feb 21, 2023
clo4
reviewed
Feb 21, 2023
sebkolind
reviewed
Feb 22, 2023
configuration/themes.md
Outdated
|
|
||
| ### Known issues | ||
| We will not have formal UI and syntax themes the like Atom, but will provide a way to override syntax styles (and more) from a single theme. |
There was a problem hiding this comment.
Suggested change
| We will not have formal UI and syntax themes the like Atom, but will provide a way to override syntax styles (and more) from a single theme. | |
| We will not have formal UI and syntax themes like Atom, but will provide a way to override syntax styles (and more) from a single theme. |
I think the is not needed here?
Co-authored-by: Robert Clover <[email protected]>
Co-authored-by: Robert Clover <[email protected]>
Co-authored-by: Sebastian L. K. Sørensen <[email protected]>
Co-authored-by: Sebastian L. K. Sørensen <[email protected]>
|
Thanks for the comments/corrections y'all. Going to hack on this a bit on the plane. This may still be open for a while while we develop the vision for what will be in the initial themes 1.0 spec. |
Co-authored-by: Sebastian L. K. Sørensen <[email protected]>
Co-authored-by: Sebastian L. K. Sørensen <[email protected]>
Co-authored-by: Robert Clover <[email protected]>
Co-authored-by: Sebastian L. K. Sørensen <[email protected]>
Co-authored-by: pr <[email protected]>
Co-authored-by: pr <[email protected]>
Co-authored-by: pr <[email protected]>
Co-authored-by: pr <[email protected]>
|
Thanks all for catching all my typos ❤️ |
|
Pushed a few tiny changes and then fixed the conflict with main. Things look fine to me - but you certainly know the status of theme stuff more than I do 🤣 |
|
Awesome gunna merge it! Thanks for contributing everyone. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the theme docs with more of our vision and roadmap for themes. It also removes some outdated theme details.