Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes JSON schema is incomplete #12319

Open
1 task done
Angelk90 opened this issue May 26, 2024 · 2 comments
Open
1 task done

Themes JSON schema is incomplete #12319

Angelk90 opened this issue May 26, 2024 · 2 comments
Labels
documentation [core label] enhancement [core label] needs info / awaiting response Issue that needs more information from the user setting Feedback for preferences, configuration, etc theme Feedback for theme configuration, accessibility, visual issues, etc

Comments

@Angelk90
Copy link

Check for existing issues

  • Completed

Describe the feature

The example scheme file is missing some attributes with the description, see some examples below.

Link: https://zed.dev/schema/themes/v0.1.0.json

conflict.background, conflict.border, created.background, created.border, deleted.background, ecc..

For example for syntax, the description of all keys is missing.

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@Angelk90 Angelk90 added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels May 26, 2024
@maxdeviant
Copy link
Member

For example for syntax, the description of all keys is missing.

The syntax keys are dynamic, so it is expected that they won't have descriptions.

@Moshyfawn Moshyfawn added needs info / awaiting response Issue that needs more information from the user theme Feedback for theme configuration, accessibility, visual issues, etc setting Feedback for preferences, configuration, etc and removed triage Maintainer needs to classify the issue labels May 27, 2024
@Angelk90
Copy link
Author

@maxdeviant : But there is no documentation on the key name scheme either, how do I know what they are to set them?
However some that are not syntax elements are missing, here are some: conflict.background, conflict.border, created.background, created.border, deleted.background, etc..

@JosephTLyons JosephTLyons removed the admin read Pending admin review label May 28, 2024
@notpeter notpeter added the documentation [core label] label Jul 29, 2024
@notpeter notpeter changed the title Missing some schema file description Themes JSON schema is incomplete Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation [core label] enhancement [core label] needs info / awaiting response Issue that needs more information from the user setting Feedback for preferences, configuration, etc theme Feedback for theme configuration, accessibility, visual issues, etc
Projects
None yet
Development

No branches or pull requests

5 participants