Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete suggetion for of is incorrect #12590

Closed
1 task done
wolfadex opened this issue Jun 2, 2024 · 2 comments
Closed
1 task done

Autocomplete suggetion for of is incorrect #12590

wolfadex opened this issue Jun 2, 2024 · 2 comments
Labels
autocompletions Feedback for code completions in the editor defect [core label] duplicate Additional reports of an existing issue elm Elm programming language support language An umbrella label for all programming languages syntax behaviors

Comments

@wolfadex
Copy link

wolfadex commented Jun 2, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

While writing Elm when I'm writing a case .. of when I type the word of Zed suggests to autocomplete with 11 other words before the literal word of, including groupsOf, oneOf, and many more.

I would expect autocomplete to first match on literal words, then words that start with the typed letters, and finally with words that match on some other heuristic.

To reproduce

  1. Create a minimal Elm project
  2. Create a definition with a body of case value of

Expected

  • When typing the word of I'd expect autocomplete to first suggest of

Actual

  • When typing the word of the literal word is the 12 suggestion

Environment

Zed: v0.137.6 (Zed)
OS: macOS 14.4.1
Memory: 24 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Screenshot 2024-06-02 at 2 08 00 PM

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@wolfadex wolfadex added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jun 2, 2024
@JosephTLyons JosephTLyons added language An umbrella label for all programming languages syntax behaviors elm Elm programming language support autocompletions Feedback for code completions in the editor and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jun 5, 2024
@JosephTLyons
Copy link
Collaborator

Hey @wolfadex - yeah, it seems we aren't always grabbing the most intuitive thing first. We've had a few other issues pop up like this for various languages - it seems like we need general fix here:

@notpeter
Copy link
Member

I'm going to close this in favor of

Thanks for reporting @wolfadex!

@notpeter notpeter added the duplicate Additional reports of an existing issue label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocompletions Feedback for code completions in the editor defect [core label] duplicate Additional reports of an existing issue elm Elm programming language support language An umbrella label for all programming languages syntax behaviors
Projects
None yet
Development

No branches or pull requests

3 participants