Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs failing occasionally on swift land extensions #17453

Open
1 task done
yaroslavyaroslav opened this issue Sep 5, 2024 · 1 comment
Open
1 task done

Breadcrumbs failing occasionally on swift land extensions #17453

yaroslavyaroslav opened this issue Sep 5, 2024 · 1 comment
Labels
defect [core label] language server failure Language server doesn't work as expected language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors navigation Feedback for workspace navigation, breadcrumbs, definitions, files, panels, etc swift

Comments

@yaroslavyaroslav
Copy link

yaroslavyaroslav commented Sep 5, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

This was initially created here alex-pinkus/tree-sitter-swift#429. but I guess it's just zed flaw.

While the outlines presents all layers solid in all tested cases. The breadcrumbs in zed editor fails to provide the full path some times. For instance it'll fail to do so if to uncomment the very last extension (I believe extension itself are the key thing here).

Here's the same issue occurred in my prod code. Any ideas why this could happens and how to fix it?

Screenshot 2024-08-23 at 17 15 44

Environment

Zed: v0.150.4 (Zed)
OS: macOS 15.0.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Source to reproduce the issue could be found here https:/alex-pinkus/tree-sitter-swift/blob/main/test/outline/outline.swift

If last three lines commented breadcrumbs working well, but when it's not it fails to present type scope to the rest of the file.

If applicable, attach your Zed.log file to this issue.

Zed.log
@yaroslavyaroslav yaroslavyaroslav added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Sep 5, 2024
@Moshyfawn Moshyfawn added language An umbrella label for all programming languages syntax behaviors language server failure Language server doesn't work as expected language server An umbrella label for all language servers swift navigation Feedback for workspace navigation, breadcrumbs, definitions, files, panels, etc and removed triage Maintainer needs to classify the issue labels Sep 10, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Sep 17, 2024
@yaroslavyaroslav
Copy link
Author

@Moshyfawn I'd disagree that this issue got anything to do with language server, if it is a zed's bug it's a bug with handling tree-sitter grammars within the breadcrumbs code only (outline provides correct outline of the very same code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] language server failure Language server doesn't work as expected language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors navigation Feedback for workspace navigation, breadcrumbs, definitions, files, panels, etc swift
Projects
None yet
Development

No branches or pull requests

3 participants