Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh metadata if necessary on deliver_message #901

Merged
merged 2 commits into from
May 18, 2021

Conversation

wamaral
Copy link
Contributor

@wamaral wamaral commented May 7, 2021

This introduces a very small change, to ensure a stale cluster gets its metadata refreshed when using Kafka::Client#deliver_message

See #900 for details and motivation

Copy link
Contributor

@dasch dasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you add an entry to the changelog?

@wamaral
Copy link
Contributor Author

wamaral commented May 17, 2021

@dasch Absolutely! Done on 4b4f6bf

@dasch
Copy link
Contributor

dasch commented May 18, 2021

Thanks!

@dasch dasch merged commit 65e4af5 into zendesk:master May 18, 2021
sarcilav added a commit to catawiki/ruby-kafka that referenced this pull request Aug 9, 2022
Refresh metadata if necessary on deliver_message zendesk#901
sarcilav added a commit to catawiki/ruby-kafka that referenced this pull request Aug 22, 2022
Refresh metadata if necessary on deliver_message zendesk#901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka::Client#deliver_message does not refresh metadata of a stale cluster
2 participants