Make ssl_ca_cert_file_path support an array of files #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syedriko
force-pushed
the
ssl_ca_cert_file_path_array
branch
from
8a609ea
to
93d6463
Compare
You're welcome! I didn't mean to just drop a PR on your lap without an explanation but got pulled into something else. This change really helps us avoid parsing certs in the Fluentd Kafka plugin. |
ashie
added a commit
to syedriko/fluent-plugin-kafka
that referenced
this pull request
Aug 26, 2021
Array support of ssl_ca_cert_file_path is needed: zendesk/ruby-kafka#905 fluent#410 Signed-off-by: Takuro Ashie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed change to facilitate fixing fluent/fluent-plugin-kafka#287. It would help to avoid parsing certs in the upper level code that should not need to know how to do that.