Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: switch from babel-eslint to @babel/eslint-parser #176

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Oct 16, 2021

  • BREAKING CHANGE?

Description

Defaults to the updated @babel-eslint/parser instead of the unmaintained babel-eslint. See https://www.npmjs.com/package/@babel/eslint-parser for support rationale.

Details

Also bumps eslint-plugin-react-hooks to the alpha version with support for eslint 8.x.

Tested locally linked package with yarn lint:js on react-components with version bumps for:

  • @typescript-eslint/eslint-plugin v5.0.0
  • @typescript-eslint/parser v5.0.0
  • eslint v8.0.1
  • eslint-plugin-jest v25.2.1
  • eslint-plugin-react-hooks v4.2.1-alpha-930c9e7ee-20211015

...and results in 33 expected problems (32 errors, 1 warning), most of which will be addressed by fixing for the new jest/require-hook rule.

@jzempel jzempel requested a review from a team as a code owner October 16, 2021 01:47
"eslint": "8.0.1",
"eslint-plugin-jest": "25.2.1",
"eslint-plugin-jsx-a11y": "6.4.1",
"eslint-plugin-node": "11.1.0",
"eslint-plugin-notice": "0.9.10",
"eslint-plugin-react": "7.26.1",
"eslint-plugin-react-hooks": "4.2.0",
"eslint-plugin-react-hooks": "4.2.1-alpha-930c9e7ee-20211015",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this but looks like it's necessary. Something we should keep our 👀 on but eslint config is in the lower risk category as a dev tool so 🤷‍♂️ .

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned here: facebook/react#22248

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, it should be a temporary solution for the time being.

@Francois-Esquire Francois-Esquire merged commit 59d9042 into main Oct 19, 2021
@Francois-Esquire Francois-Esquire deleted the jzempel/update-parser branch October 19, 2021 14:11
@jzempel jzempel mentioned this pull request Nov 24, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants