Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearly document internal kernel interfaces #2144

Closed
zephyrbot opened this issue Aug 1, 2016 · 6 comments
Closed

clearly document internal kernel interfaces #2144

zephyrbot opened this issue Aug 1, 2016 · 6 comments
Assignees
Labels
area: Documentation area: Kernel Enhancement Changes/Updates/Additions to existing features priority: medium Medium impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

zephyrbot commented Aug 1, 2016

Reported by Andrew Boie:

As a developer porting Zephyr to a new architecture, I would like the internal APIs that the kernel expects architectures to implement to be clearly documented in header files rather than it being a trial-and-error exercise.

Examples would be some but not all members of struct tcs. Certain functions like _IntLibInit, etc. _IS_IN_ISR.
There's also an assortment of headers in the codebase which #ifdef on all arches, variously failing silently or loudly if the new architecture hasn't added there yet. These should be consolidated.

The required members of tcs and others should be defined in a new struct that gets embedded within the respective arch-specific implementations.

(Imported from Jira ZEP-618)

@zephyrbot
Copy link
Collaborator Author

by Andrew Boie:

Per Ben this should wait until the unified kernel goes out.

@zephyrbot
Copy link
Collaborator Author

by Sharron LIU:

As a tester, would need distinguish internal API/data structure/fields, too!
Internal stuff should not be test focus, as test cases using internal stuff are less common across arch/platform.

@zephyrbot
Copy link
Collaborator Author

by Sharron LIU:

To my understanding today, in kenel header file, naming space "_*" is reserved for internal usage.

But I think, unless every internal API/fields/structure has been documented (that is, an expected list given), otherwise it would not be possible from QA side to verify all internal stuff are aligned to "_*" naming space. So I would mark this "NotTest".

@zephyrbot
Copy link
Collaborator Author

by Mark Linkmeyer:

Fixing incorrect priority

@zephyrbot
Copy link
Collaborator Author

by David Kinder:

The title and references to nano-kernel in this Jira should be changed to be about the kernel in general, i.e., Update header files to clearly document internal APIs that the kernel expects architectures to implement ...

@zephyrbot zephyrbot added priority: low Low impact/importance bug area: Kernel area: Documentation Enhancement Changes/Updates/Additions to existing features labels Sep 23, 2017
@zephyrbot zephyrbot mentioned this issue Sep 23, 2017
49 tasks
@nashif nashif added priority: medium Medium impact/importance bug and removed priority: low Low impact/importance bug labels Apr 14, 2019
@nashif
Copy link
Member

nashif commented Nov 21, 2019

fixed in #20257

@nashif nashif closed this as completed Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Documentation area: Kernel Enhancement Changes/Updates/Additions to existing features priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

3 participants