Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: controller: nRF5x: refactor radio_nrf5_ppi.h #26118

Closed
kruithofa opened this issue Jun 11, 2020 · 1 comment
Closed

Bluetooth: controller: nRF5x: refactor radio_nrf5_ppi.h #26118

kruithofa opened this issue Jun 11, 2020 · 1 comment
Assignees
@cvinayak
Labels
area: Bluetooth Controller area: Bluetooth Enhancement Changes/Updates/Additions to existing features platform: nRF Nordic nRFx

Comments

@kruithofa
Copy link
Collaborator

Is your enhancement proposal related to a problem? Please describe.
The conditional compilation makes the code more difficult to read/understand.
There is also inconsistency in the functionality for the routine 'hal_radio_switch_disable()', in radio_nrf5_ppi.h lines 454 vs. 1268

Describe the solution you'd like

  • Split the nrf5_ppi.h in 2 files for improved readability
  • Make the different routines consistent

Describe alternatives you've considered
[None]

Additional context
See PR #26019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvinayak cvinayak

Labels
area: Bluetooth Controller area: Bluetooth Enhancement Changes/Updates/Additions to existing features platform: nRF Nordic nRFx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cvinayak @carlescufi @kruithofa