Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver: espi: mchp: eSPI OOB driver does not support callbacks for incoming OOB messages from eSPI master. #28249

Closed
AdiIntel opened this issue Sep 9, 2020 · 1 comment · Fixed by #32087
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug platform: Microchip MEC Microchip MEC Platform priority: low Low impact/importance bug

Comments

@AdiIntel
Copy link
Contributor

AdiIntel commented Sep 9, 2020

Describe the bug
Current eSPI driver allows to transmit & receive OOB messages with explicit function calls.
Driver should also allow to add callbacks to support incoming OOB messages initiated from eSPI master, so that slave (EC) doesn't have to keep polling for it always.
When the slave shows OOB status as free, then only master can send the OOB message. For this, OOB status should also be set as free always with callback set.

To Reproduce
Steps to reproduce the behavior:

  1. Use eSPI driver sample code, and send an OOB message.
  2. OOB status fields can be seen with Acute analyzer logs.

Expected behavior
eSPI OOB channel status should be seen as free in Acute log.
eSPI slave (EC) driver should allow incoming message handlers.

Impact
With CSME master, incoming OOB messages won't be handled.

Environment (please complete the following information):

  • Toolchain (e.g Zephyr SDK, ...)
@AdiIntel AdiIntel added the bug The issue is a bug, or the PR is fixing a bug label Sep 9, 2020
@albertofloyd albertofloyd self-assigned this Sep 9, 2020
@MaureenHelm MaureenHelm added the priority: low Low impact/importance bug label Sep 15, 2020
@albertofloyd albertofloyd added the platform: Microchip MEC Microchip MEC Platform label Oct 21, 2020
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug platform: Microchip MEC Microchip MEC Platform priority: low Low impact/importance bug
Projects
None yet
4 participants