Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTS: Test framework: Bluetooth: GATT/SR/GAC/BI-01-C - FAIL #29224

Closed
KKopyscinski opened this issue Oct 15, 2020 · 11 comments
Closed

PTS: Test framework: Bluetooth: GATT/SR/GAC/BI-01-C - FAIL #29224

KKopyscinski opened this issue Oct 15, 2020 · 11 comments
Assignees
Labels
area: Bluetooth Host area: Bluetooth Qualification Bluetooth Qualification -related issues and pull requests area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@KKopyscinski
Copy link
Collaborator

KKopyscinski commented Oct 15, 2020

Describe the bug
When EATT is enabled, MTU exchange request should be met with response with error 0x06 (BT_ATT_ERR_NOT_SUPPORTED). Instead, 0x0000 is received.

Steps To Reproduce
GATT/SR/GAC/BI-01-C can be enabled by ICS GATT 2/3, which can be enabled for Core 5.2 spec:

Attribute Protocol Supported (L2CAP fixed EATT PSM supported)
Excluded IF SUM ICS 31/17 “Core Spec Version 4.2” OR SUM ICS 31/18 “Core Specification
Version 4.2 + HS” OR SUM ICS 31/19 "Core Specification Version 5.0" OR SUM ICS 31/20 "Core
Specification Version 5.1" OR (NOT GATT 2/1 “Attribute Protocol Supported over BR/EDR (L2CAP
fixed channel support)” AND NOT GATT 2/2 ” Attribute Protocol Supported over LE”) is supported,
otherwise Optional.

As this is new test, autopts should have it implemented:
https:/KKopyscinski/auto-pts/tree/gatt-sr-gac-bi-01

A clear and concise description of what the bug is.
PTS ends test with FAIL result, with verdict description:

FAILED: Request not supported error is expected but the received response code = 0x0000.

PTS logs attached
GATT_SR_GAC_BI_01_C_2020_10_15_09_53_01.zip

@KKopyscinski KKopyscinski added the bug The issue is a bug, or the PR is fixing a bug label Oct 15, 2020
@nashif nashif added area: Bluetooth priority: medium Medium impact/importance bug labels Oct 16, 2020
@jhedberg jhedberg assigned joerchan and Vudentz and unassigned jhedberg Oct 20, 2020
@carlescufi
Copy link
Member

@KKopyscinski will you submit a fix for this?

@carlescufi
Copy link
Member

@KKopyscinski will you submit a fix for this?

Answering the question myself: Yes, but in the future. This issue is just here to remind us of the qualification problem.

@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Dec 22, 2020
@github-actions github-actions bot closed this as completed Jan 5, 2021
@joerchan joerchan reopened this Jan 5, 2021
@joerchan joerchan removed the Stale label Jan 5, 2021
@carlescufi carlescufi added area: Bluetooth Host area: Bluetooth Qualification Bluetooth Qualification -related issues and pull requests labels Jan 14, 2021
@carlescufi carlescufi added this to the v2.5.0 milestone Jan 14, 2021
@carlescufi carlescufi added priority: low Low impact/importance bug and removed priority: medium Medium impact/importance bug labels Jan 21, 2021
@carlescufi
Copy link
Member

Downgrading to low because there is a plan to address all qualification-related issues in the Host in the near future as part of a new qualification automated test plan.

@Vudentz
Copy link
Contributor

Vudentz commented Jan 25, 2021

Afaik this is already handled:

https:/zephyrproject-rtos/zephyr/blob/master/subsys/bluetooth/host/att.c#L521

I wonder if this isn't a PTS problem as it should only work when sending on the non-fixed cid L2CAP channel.

@joerchan
Copy link
Contributor

Looked into the logs, I cannot see the MTU exchange mentioned. The connection is disconnected immediately after the L2CAP credit based connection request & response.

@carlescufi
Copy link
Member

Looked into the logs, I cannot see the MTU exchange mentioned. The connection is disconnected immediately after the L2CAP credit based connection request & response.

According to all of this information from @Vudentz and @joerchan, this seems to be a test issue, and not a Zephyr implementation one.

@carlescufi carlescufi removed this from the v2.5.0 milestone Feb 4, 2021
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Apr 6, 2021
@joerchan
Copy link
Contributor

joerchan commented Apr 7, 2021

@KKopyscinski Can you please clarify this issue?

@KKopyscinski
Copy link
Collaborator Author

@joerchan I don’t remember now more than I wrote here, but I’ll revisit this issue on Monday

@github-actions github-actions bot removed the Stale label Apr 8, 2021
@KKopyscinski
Copy link
Collaborator Author

Last time it was tested on PTS v7.6.x. I tested it today on v8.0.2 and it passes, so indeed it was PTS issue. I'm closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Host area: Bluetooth Qualification Bluetooth Qualification -related issues and pull requests area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

6 participants