Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hci_uart uses wrong BT_BUF_ACL_SIZE on dual chip solutions + multicore #30441

Closed
jostn opened this issue Dec 4, 2020 · 2 comments · Fixed by #30552
Closed

hci_uart uses wrong BT_BUF_ACL_SIZE on dual chip solutions + multicore #30441

jostn opened this issue Dec 4, 2020 · 2 comments · Fixed by #30552
Assignees
@joerchan
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@jostn
Copy link
Contributor

jostn commented Dec 4, 2020

Describe the bug
hci_raw.h has a dependency on CONFIG_BT_CTLR_TX_BUFFER_SIZE

This option can not be set for dual chip solutions for multicores platorms like nrf5340pdk_nrf5340_cpuapp, leading to a max hci data payload of 69 bytes.

To Reproduce
Steps to reproduce the behavior:
west build -p auto -b nrf5340pdk_nrf5340_cpuapp -dapp samples/bluetooth/hci_uart
west build -p auto -b nrf5340pdk_nrf5340_cpunet -dnet samples/bluetooth/hci_rpmsg

Use HCI_LE_Set_Data_Length to establish a connection and update the data length (251 octets, 2120us)
HCI data packets with data length > 69 bytes are now dropped because they do not fit in the buffer between the application core and the network core.

Expected behavior
It should be possible to send the maximum LL payload between the cores (251 bytes)

Impact
Many bluetooth conformance tests are failing due to this.

Environment (please complete the following information):

  • Linux
  • Zephyr SDK
@jostn jostn added the bug The issue is a bug, or the PR is fixing a bug label Dec 4, 2020
@jostn jostn mentioned this issue Dec 4, 2020
Closed
@carlescufi
Copy link
Member

@jostn would you mind sending a Pull Request yourself if @joerchan is too busy?

@nashif nashif added the priority: low Low impact/importance bug label Dec 15, 2020
@carlescufi
Copy link
Member

@jostn and @joerchan could you please follow-up on this one?

@joerchan joerchan mentioned this issue Feb 10, 2021
Merged
jostn added a commit to jostn/zephyr that referenced this issue Mar 8, 2021
@jostn
Bluetooth: HCI: Add option CONFIG_BT_HCI_ACL_DATA_SIZE
bea9ece 
Add the option CONFIG_BT_HCI_ACL_DATA_SIZE which allows the user
to configure the max HCI ACL data payload. This is needed for platorms
where the BLE LL, HCI uart and host run on three different cores.

Fixes: zephyrproject-rtos#30441

Signed-off-by: Johan Stridkvist <[email protected]>
jostn added a commit to jostn/zephyr that referenced this issue Mar 11, 2021
@jostn
Bluetooth: HCI: Add option CONFIG_BT_HCI_ACL_DATA_SIZE
a1396ab 
Add the option CONFIG_BT_HCI_ACL_DATA_SIZE which allows the user
to configure the max HCI ACL data payload. This is needed for platorms
where the BLE LL, HCI uart and host run on three different cores.

Fixes: zephyrproject-rtos#30441

Signed-off-by: Johan Stridkvist <[email protected]>
omSquare-bot pushed a commit to omSquare/zephyr that referenced this issue Mar 12, 2021
@jostn @jhedberg
Bluetooth: HCI: Add option CONFIG_BT_HCI_ACL_DATA_SIZE
a81765b 
Add the option CONFIG_BT_HCI_ACL_DATA_SIZE which allows the user
to configure the max HCI ACL data payload. This is needed for platorms
where the BLE LL, HCI uart and host run on three different cores.

Fixes: zephyrproject-rtos#30441

Signed-off-by: Johan Stridkvist <[email protected]>
ryanjh pushed a commit to ryanjh/zephyr that referenced this issue Mar 23, 2021
@jostn @anangl
[nrf fromtree] Bluetooth: HCI: Add option CONFIG_BT_HCI_ACL_DATA_SIZE
7495dfa 
Add the option CONFIG_BT_HCI_ACL_DATA_SIZE which allows the user
to configure the max HCI ACL data payload. This is needed for platorms
where the BLE LL, HCI uart and host run on three different cores.

Fixes: zephyrproject-rtos#30441

Signed-off-by: Johan Stridkvist <[email protected]>
(cherry picked from commit a81765b)
Signed-off-by: Andrzej Głąbek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joerchan joerchan

Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bluetooth: HCI: Add option CONFIG_BUF_ACL_DATA_LEN jostn/zephyr
4 participants
@nashif @joerchan @carlescufi @jostn