Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples/bluetooth/mesh is not helpful #31031

Closed
pabigot opened this issue Dec 28, 2020 · 4 comments · Fixed by #33476
Closed

samples/bluetooth/mesh is not helpful #31031

pabigot opened this issue Dec 28, 2020 · 4 comments · Fixed by #33476
Assignees
Labels
area: Bluetooth Mesh bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@pabigot
Copy link
Collaborator

pabigot commented Dec 28, 2020

samples/bluetooth/mesh lacks any description of what it actually does, or how to verify that it does anything at all.

The documentation specifies that it supports automated provisioning, and messages do show that if samples/bluetooth/mesh_provisioner is running it will be "provisioned", but on completion of provisioning there is no observable behavior between it and an unprovisioned node. Also it appears the provisioning is not preserved: on reset the node is again provisioned. Adding a second node appears to result in it using the same identify, which has no further effect except to cause unexpected xact warnings from bt_mesh_pb_adv.

I'm calling this a bug because people wanting to see how to use Zephyr for Bluetooth mesh have two options: this sample, and mesh_demo which requires tedious hard-coded provisioning. IMO samples should be useful. At a minimum more documentation should be provided to explain why this is even present. To be useful it could maybe implement something like having switches turn LEDs on or off, since the models are stubbed in.

@pabigot pabigot added the bug The issue is a bug, or the PR is fixing a bug label Dec 28, 2020
@nashif nashif added the priority: low Low impact/importance bug label Jan 4, 2021
@carlescufi
Copy link
Member

The conclusion is that we should turn this into a basic mesh sample that provides the following functionality:

  • Use the on/off service to turn on-board LEDs on and off
  • Document how to provision the app and turn the LED on and off from BlueZ/mobile app

@carlescufi
Copy link
Member

@trond-snekvik any updates on this one?

@pabigot
Copy link
Collaborator Author

pabigot commented Mar 8, 2021

@carlescufi @trond-snekvik is this expected soon (this month)?

@trond-snekvik
Copy link
Contributor

Yes, I'll start it later this week.

trond-snekvik added a commit to trond-snekvik/zephyr that referenced this issue Mar 19, 2021
Populates the onoff server stubs in the Bluetooth Mesh sample, and
implements generic LED based hardware support to include more boards.

Fixes zephyrproject-rtos#31031.

Signed-off-by: Trond Einar Snekvik <[email protected]>
trond-snekvik added a commit to trond-snekvik/zephyr that referenced this issue Mar 26, 2021
Populates the onoff server stubs in the Bluetooth Mesh sample, and
implements generic LED based hardware support to include more boards.

Fixes zephyrproject-rtos#31031.

Signed-off-by: Trond Einar Snekvik <[email protected]>
jhedberg pushed a commit that referenced this issue Mar 26, 2021
Populates the onoff server stubs in the Bluetooth Mesh sample, and
implements generic LED based hardware support to include more boards.

Fixes #31031.

Signed-off-by: Trond Einar Snekvik <[email protected]>
pabigot pushed a commit to pabigot/zephyr that referenced this issue Mar 28, 2021
Populates the onoff server stubs in the Bluetooth Mesh sample, and
implements generic LED based hardware support to include more boards.

Fixes zephyrproject-rtos#31031.

Signed-off-by: Trond Einar Snekvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Mesh bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants