Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bbc_microbit build failure is blocking CI #32599

Closed
mbolivar-nordic opened this issue Feb 24, 2021 · 3 comments · Fixed by #32600
Closed

bbc_microbit build failure is blocking CI #32599

mbolivar-nordic opened this issue Feb 24, 2021 · 3 comments · Fixed by #32600
Assignees
@cvinayak @carlescufi
Labels
area: Bluetooth Controller area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug Regression Something, which was working, does not anymore

Comments

@mbolivar-nordic
Copy link
Contributor

mbolivar-nordic commented Feb 24, 2021 •
edited
Loading

The bluetooth.mesh.main.microbit case in tests/bluetooth/mesh is failing and causing CI failures in other PRs.

I'm getting this error in CI in an unrelated PR (#31965):

/workdir/zephyr/subsys/bluetooth/controller/ll_sw/ull.c:106:7: error: 'BT_CTLR_CONN_MAX' undeclared here (not in a function)
  106 |       BT_CTLR_CONN_MAX + \
      |       ^~~~~~~~~~~~~~~~

Details in https://buildkite.com/zephyr/zephyr/builds/21988#868a8486-8a62-4f2a-9274-f55581716664.

This reproduces for me on master with:

west build -p -b bbc_microbit -s tests/bluetooth/mesh -- -DCONF_FILE=$PWD/tests/bluetooth/mesh/microbit.conf

I'm using Zephyr SDK 0.12.2.
@mbolivar-nordic mbolivar-nordic added bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug labels Feb 24, 2021
@mbolivar-nordic
Copy link
Contributor Author

@cvinayak bisection from v2.5.0 shows bee6aa3 as the first commit with this error, but before that I get RAM overflows.

mbolivar-nordic added a commit to mbolivar-nordic/zephyr that referenced this issue Feb 24, 2021
@mbolivar-nordic
Bluetooth: controller: fix typo
9a72aed 
A macro is misspelled.

Fixes: zephyrproject-rtos#32599
Signed-off-by: Martí Bolívar <[email protected]>
@mbolivar-nordic mbolivar-nordic mentioned this issue Feb 24, 2021
Merged
@mbolivar-nordic
Copy link
Contributor Author

I got a hint from @cvinayak offline on how to fix and posted a PR. This restores the old RAM overflow behavior.

@cvinayak cvinayak added has-pr area: Bluetooth area: Bluetooth Controller Regression Something, which was working, does not anymore labels Feb 24, 2021
@jhedberg
Copy link
Member

There’s a fix for the RAM overflow in #32562

nashif pushed a commit that referenced this issue Feb 24, 2021
@mbolivar-nordic @nashif
Bluetooth: controller: fix typo
31c1dc5 
A macro is misspelled.

Fixes: #32599
Signed-off-by: Martí Bolívar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvinayak cvinayak

@carlescufi carlescufi

Labels
area: Bluetooth Controller area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug Regression Something, which was working, does not anymore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bluetooth: controller: fix typo mbolivar-nordic/zephyr
4 participants
@jhedberg @cvinayak @carlescufi @mbolivar-nordic