Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function z_find_first_thread_to_unpend() missing coverage in sched.c #32691

Closed
yingmingx opened this issue Feb 26, 2021 · 2 comments · Fixed by #32891
Closed

Function z_find_first_thread_to_unpend() missing coverage in sched.c #32691

yingmingx opened this issue Feb 26, 2021 · 2 comments · Fixed by #32891
Assignees
@yerabolu
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@yingmingx
Copy link
Collaborator

Describe the bug
Function z_find_first_thread_to_unpend() missing coverage in sched.c.

To Reproduce
Steps to reproduce the behavior:

  1. twister -p qemu_x86 --coverage -T tests/kernel

Expected behavior
It's probably dead code that should be removed.

Environment (please complete the following information):

OS: ubuntu1~18.04
Toolchain zephyr-sdk-0.12.1
Commit id 5de3f85
@yingmingx yingmingx added the bug The issue is a bug, or the PR is fixing a bug label Feb 26, 2021
@andyross
Copy link
Contributor

andyross commented Mar 1, 2021

Agreed. This looks to have been orphaned fairly recently; there was a scheduler race fix a while back (that exposed another issue, and begat the big abort rewrite and bug hunt of the past two weeks) that addressed synchronization issues by combining operations in a few spots. This looks like a "half" of the operation that got combined.

@rljordan rljordan assigned yerabolu and unassigned andyross Mar 1, 2021
@nashif nashif added the priority: low Low impact/importance bug label Mar 2, 2021
@yerabolu
Copy link
Contributor

yerabolu commented Mar 3, 2021

Working on the changes and will submit a PR soon.

@yerabolu yerabolu mentioned this issue Mar 4, 2021
Merged
yerabolu added a commit to yerabolu/zephyr that referenced this issue Mar 4, 2021
@yerabolu
kernel: sched: removing dead code
549a45d 
Due to the recent changes to scheduler z_find_first_thread_to_unpend
& z_remove_thread_from_ready_q are not used anymore. So removing the
dead code.

fixes: zephyrproject-rtos#32691

Signed-off-by: Spoorthy Priya Yerabolu <[email protected]>
ioannisg pushed a commit that referenced this issue Mar 5, 2021
@yerabolu @ioannisg
kernel: sched: removing dead code
4118ed1 
Due to the recent changes to scheduler z_find_first_thread_to_unpend
& z_remove_thread_from_ready_q are not used anymore. So removing the
dead code.

fixes: #32691

Signed-off-by: Spoorthy Priya Yerabolu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yerabolu yerabolu

Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kernel: sched: removing dead code yerabolu/zephyr
4 participants
@nashif @andyross @yerabolu @yingmingx