Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsys: Logging: Functions purely to avoid compiling error affects test coverage #32735

Closed
mengxianglinx opened this issue Mar 1, 2021 · 1 comment
Assignees
Labels
area: Logging bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug Stale

Comments

@mengxianglinx
Copy link
Collaborator

Describe the bug
For function "void z_impl_z_log_string_from_user(uint32_t src_level_val, const char *str)", it be called neither in user space nor non-user space.
And for z_vrfy_z_log_hexdump_from_user, log_from_user, log_generic_from_user, log_hexdump_from_user defined for non-user space (line 1124-1170 in log_cor.c) are never called.
They must be there for reasons, but these functions affects test coverage.
Actually, the logic of defining these functions need refactor ,basically there is no reason to "do_some_thing_from_user" in non-user space.

@mengxianglinx mengxianglinx added bug The issue is a bug, or the PR is fixing a bug area: Logging labels Mar 1, 2021
@nashif nashif added the priority: low Low impact/importance bug label Mar 2, 2021
@github-actions
Copy link

github-actions bot commented May 2, 2021

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Logging bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug Stale
Projects
None yet
Development

No branches or pull requests

3 participants