Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :219499] Argument cannot be negative in tests/net/socket/af_packet/src/main.c #32942

Closed
zephyrbot opened this issue Mar 5, 2021 · 2 comments
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/tests/net/socket/af_packet/src/main.c

Category: Error handling issues
Function: prepare_udp_socket
Component: Tests
CID: 219499

Details:

ret = bind(sock, (struct sockaddr *) sockaddr, sizeof(*sockaddr));

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 5, 2021
@gudnimg
Copy link
Contributor

gudnimg commented Mar 13, 2021

I think this is a false positive since sock is checked with an assertion above:

zassert_true(sock >= 0, "Cannot create DGRAM (UDP) socket (%d)", sock);

@jukkar
Copy link
Member

jukkar commented Mar 15, 2021

Yep, Coverity does not understand that zassert() does not return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

5 participants