Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :219497] Logically dead code in subsys/bluetooth/host/gatt.c #32944

Closed
zephyrbot opened this issue Mar 5, 2021 · 4 comments
Closed
Assignees
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Milestone

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/subsys/bluetooth/host/gatt.c

Category: Control flow issues
Function: cf_set_value
Component: Bluetooth
CID: 219497

Details:

cfg->data[i] |= value[i];

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 5, 2021
@joerchan
Copy link
Contributor

joerchan commented Mar 5, 2021

This is logically dead because there is not enough bits yet defined to take this branch. Once more bits are added this code-path will be needed.

@jhedberg You agree that we should close this as intentional?

@github-actions
Copy link

github-actions bot commented May 5, 2021

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label May 5, 2021
@nashif nashif removed the Stale label May 5, 2021
@galak galak added this to the v2.6.0 milestone May 11, 2021
@carlescufi
Copy link
Member

This is logically dead because there is not enough bits yet defined to take this branch. Once more bits are added this code-path will be needed.

@jhedberg You agree that we should close this as intentional?

I've looked at the code now and I agree completely. Will close this.

@carlescufi
Copy link
Member

Marked as false positive in Coverity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

7 participants