Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID :219494] Logically dead code in boards/xtensa/intel_s1000_crb/pinmux.c #32946

Closed
zephyrbot opened this issue Mar 5, 2021 · 0 comments · Fixed by #33017
Closed

[Coverity CID :219494] Logically dead code in boards/xtensa/intel_s1000_crb/pinmux.c #32946

zephyrbot opened this issue Mar 5, 2021 · 0 comments · Fixed by #33017
Assignees
@sathishkuttan @dcpleung
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/boards/xtensa/intel_s1000_crb/pinmux.c

Category: Control flow issues
Function: intel_s1000_pinmux_init
Component: Other
CID: 219494

Details:

zephyr/boards/xtensa/intel_s1000_crb/pinmux.c

Line 33 in bd97359

return -ENXIO;

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 5, 2021
dcpleung added a commit to dcpleung/zephyr that referenced this issue Mar 7, 2021
@dcpleung
boards: intel_s1000_crb: device_is_ready instead of NULL check
f3b05f0 
This changes the NULL check to be using device_is_ready().

Fixes zephyrproject-rtos#32946
CID #219494

Signed-off-by: Daniel Leung <[email protected]>
@dcpleung dcpleung mentioned this issue Mar 7, 2021
Merged
nashif pushed a commit that referenced this issue Mar 8, 2021
@dcpleung @nashif
boards: intel_s1000_crb: device_is_ready instead of NULL check
72dfb34 
This changes the NULL check to be using device_is_ready().

Fixes #32946
CID #219494

Signed-off-by: Daniel Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sathishkuttan sathishkuttan

@dcpleung dcpleung

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

boards: intel_s1000_crb: device_is_ready instead of NULL check dcpleung/zephyr
3 participants
@sathishkuttan @zephyrbot @dcpleung