Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :219490] Unsigned compared against 0 in drivers/wifi/esp/esp.c #32950

Closed
zephyrbot opened this issue Mar 5, 2021 · 3 comments
Closed
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/drivers/wifi/esp/esp.c

Category: Control flow issues
Function: esp_dns_work
Component: Drivers
CID: 219490

Details:

for (i = 0; i < ESP_MAX_DNS; i++) {

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 5, 2021
@mniestroj
Copy link
Member

False positive, as ESP_MAX_DNS can be > 0 when DNS resolver is enabled.

@ceolin
Copy link
Member

ceolin commented Mar 16, 2021

False positive, as ESP_MAX_DNS can be > 0 when DNS resolver is enabled.

Hi @mniestroj please next time either you mark as false positive in Coverity (with the justification) or ask someone to do it, otherwise this issue will automatically be re-opened in the next scan. I've done it for this one though.

@mniestroj
Copy link
Member

@ceolin Thanks for letting me know. How can I get Coverity account/permission to do that next time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

3 participants