Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :219480] Out-of-bounds read in lib/os/cbprintf_nano.c #32959

Closed
zephyrbot opened this issue Mar 5, 2021 · 3 comments
Closed

[Coverity CID :219480] Out-of-bounds read in lib/os/cbprintf_nano.c #32959

zephyrbot opened this issue Mar 5, 2021 · 3 comments
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/lib/os/cbprintf_nano.c

Category: Memory - illegal accesses
Function: cbvprintf
Component: Other
CID: 219480

Details:

https:/zephyrproject-rtos/zephyr/blob/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/lib/os/cbprintf_nano.c

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug labels Mar 5, 2021
@nashif nashif assigned pabigot and unassigned nashif, andyross and dcpleung Mar 5, 2021
@pabigot pabigot assigned npitre and unassigned pabigot Mar 5, 2021
@pabigot
Copy link
Collaborator

pabigot commented Mar 5, 2021

This is an out-of-bounds read at line 208 where convert_value accesses buf[21] in a 21-byte buffer introduced in fb73ac3.

On short inspection it seems to be a false positive, but it's not the sort of mistake Coverity should make.

@npitre
Copy link
Collaborator

npitre commented Mar 5, 2021 via email

@npitre
Copy link
Collaborator

npitre commented Mar 12, 2021

The coverity link is giving me a 401.
As I said, this is a false positive.
Closing.

@npitre npitre closed this as completed Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

6 participants