Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID :219625] Unchecked return value in subsys/bluetooth/mesh/proxy.c #33051

Closed
zephyrbot opened this issue Mar 7, 2021 · 0 comments
Closed

[Coverity CID :219625] Unchecked return value in subsys/bluetooth/mesh/proxy.c #33051

zephyrbot opened this issue Mar 7, 2021 · 0 comments
Assignees
@jhedberg @joerchan @Vudentz @trond-snekvik
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/subsys/bluetooth/mesh/proxy.c

Category: Error handling issues
Function: bt_mesh_proxy_gatt_enable
Component: Bluetooth
CID: 219625

Details:

zephyr/subsys/bluetooth/mesh/proxy.c

Line 787 in bd97359

bt_gatt_service_register(&proxy_svc);

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 7, 2021
trond-snekvik added a commit to trond-snekvik/zephyr that referenced this issue Mar 8, 2021
@trond-snekvik
Bluetooth: Mesh: Explicitly ignore gatt_service_register return code
e63d618 
The error code from gatt_service_register is being ignored to ensure
that repeated actions still complete. Do this explicitly by adding
(void) casts, resolving coverity warnings on accidental error code
ignores.

Fixes zephyrproject-rtos#33051.
Fixes zephyrproject-rtos#33074.

Signed-off-by: Trond Einar Snekvik <[email protected]>
@nashif nashif closed this as completed in f9d4159 Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhedberg jhedberg

@joerchan joerchan

@Vudentz Vudentz

@trond-snekvik trond-snekvik

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jhedberg @joerchan @Vudentz @trond-snekvik @zephyrbot