Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :219556] Self assignment in drivers/espi/host_subs_npcx.c #33089

Closed
zephyrbot opened this issue Mar 7, 2021 · 1 comment · Fixed by #33167
Closed

[Coverity CID :219556] Self assignment in drivers/espi/host_subs_npcx.c #33089

zephyrbot opened this issue Mar 7, 2021 · 1 comment · Fixed by #33167
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/drivers/espi/host_subs_npcx.c

Category: Incorrect expression
Function: npcx_host_init_subs_core_domain
Component: Drivers
CID: 219556

Details:

inst_shm->SMC_STS = inst_shm->SMC_STS;

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 7, 2021
@nashif nashif assigned MulinChao and unassigned albertofloyd and scottwcpg Mar 7, 2021
@MulinChao
Copy link
Collaborator

All bit fields of SMC_STS is RW/1C. It's common for MCU to clear all pending bits during initialization. If solving 'Self assignment ' issue is necessary, the ideas I have to replace inst_shm->SMC_STS = inst_shm->SMC_STS; are:
option 1:
inst_shm->SMC_STS = 0x7B /* bit 7 & 2 are reserved */
option 2:
uint8_t tmp = inst_shm->SMC_STS; inst_shm->SMC_STS = tmp;

Any further comment on this issue is appreciated.

MulinChao added a commit to MulinChao/zephyr that referenced this issue Mar 9, 2021
This CL removes self-assignment of SMC_STS register for clearing its
status.

Fixes zephyrproject-rtos#33089.

Signed-off-by: Mulin Chao <[email protected]>
nashif pushed a commit that referenced this issue Mar 9, 2021
This CL removes self-assignment of SMC_STS register for clearing its
status.

Fixes #33089.

Signed-off-by: Mulin Chao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants