Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID: 219723] Side effect in assertion in tests/kernel/queue/src/test_queue_contexts.c #33315

Closed
zephyrbot opened this issue Mar 13, 2021 · 1 comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/b4f5b9e23770f2c9cddf95fef7b9af32da309f7f/tests/kernel/queue/src/test_queue_contexts.c#L363

Category: Incorrect expression
Function: test_queue_poll_race
Component: Tests
CID: 219723

Details:

zassert_true(mid_count == 0, NULL);

357          * asleep.
358          */
359         k_queue_append(&queue, &data[0]);
360         k_queue_append(&queue, &data[1]);
361    
362         zassert_true(low_count == 0, NULL);
>>>     CID 219723:  Incorrect expression  (ASSERT_SIDE_EFFECT)
>>>     Argument "mid_count" of z_zassert() has a side effect because the variable is volatile.  The containing function might work differently in a non-debug build.
363         zassert_true(mid_count == 0, NULL);
364    
365         k_sleep(K_MSEC(10));
366    
367         zassert_true(low_count + mid_count == 2, NULL);
368    

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 13, 2021
@nashif
Copy link
Member

nashif commented Mar 13, 2021

false positive

@nashif nashif closed this as completed Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants