[Coverity CID: 219722] Resource leak in tests/lib/mem_alloc/src/main.c

[zephyrbot]

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/b4f5b9e23770f2c9cddf95fef7b9af32da309f7f/tests/lib/mem_alloc/src/main.c#L233

Category: Resource leaks
Function: test_reallocarray
Component: Tests
CID: 219722

Details:

zephyr/tests/lib/mem_alloc/src/main.c

Line 233 in b4f5b9e

ptr = reloc_ptr;

227         (void)memset(ptr, 'p', orig_size);
228    
229         char *reloc_ptr = reallocarray(ptr, 2, orig_size);
230    
231         zassert_not_null(reloc_ptr, "reallocarray failed");
232         zassert_not_null((ptr), "malloc/reallocarray failed, errno: %d", errno);
>>>     CID 219722:  Resource leaks  (RESOURCE_LEAK)
>>>     Overwriting "ptr" in "ptr = reloc_ptr" leaks the storage that "ptr" points to.
233         ptr = reloc_ptr;
234    
235         (void)memset(filled_buf, 'p', BUF_LEN);
236         zassert_true(((memcmp(ptr, filled_buf, BUF_LEN)) == 0),
237                 "realloc failed to copy malloc data, errno: %d", errno);
238    

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

[enjiamai]

After analyzing it, this is likely to be a false positive. Because after calling the reallocarray(), the original memory chuck that "ptr" point to, is no need to be free. It might become a larger or smaller memory chunk. No memory would be leak here.

I think there is no need to fix it.