Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID: 220451] Resource leak in tests/lib/mem_alloc/src/main.c #33785

Closed
zephyrbot opened this issue Mar 29, 2021 · 1 comment · Fixed by #33881
Closed

[Coverity CID: 220451] Resource leak in tests/lib/mem_alloc/src/main.c #33785

zephyrbot opened this issue Mar 29, 2021 · 1 comment · Fixed by #33881
Assignees
@enjiamai
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/169144afa1826511ee6ec3f53d590b2c0d39d3d4/tests/lib/mem_alloc/src/main.c

Category: Resource leaks
Function: test_calloc
Component: Tests
CID: 220451

Details:

https:/zephyrproject-rtos/zephyr/blob/169144afa1826511ee6ec3f53d590b2c0d39d3d4/tests/lib/mem_alloc/src/main.c

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 29, 2021
@nashif nashif assigned enjiamai and unassigned nashif Mar 29, 2021
enjiamai pushed a commit to enjiamai/zephyr that referenced this issue Mar 30, 2021
tests: lib: fix coverity issues of resource leaks for mem_alloc testcase
3407e7d 
Fix 2 resource leaks issues of coverity scan, actually the return of
NULL pointer is expected, but there is no harm done to free a NULL
pointer in our design, so adding them to pass the scan.

Fixes zephyrproject-rtos#33802	CID: 220434
Fixes zephyrproject-rtos#33785	CID: 220451

Signed-off-by: Enjia Mai <[email protected]>
@enjiamai enjiamai mentioned this issue Mar 30, 2021
Merged
@enjiamai
Copy link
Collaborator

Submit a PR #33881 to fix it.

nashif pushed a commit that referenced this issue Mar 31, 2021
@nashif
tests: lib: fix coverity issues of resource leaks for mem_alloc testcase
d111637 
Fix 2 resource leaks issues of coverity scan, actually the return of
NULL pointer is expected, but there is no harm done to free a NULL
pointer in our design, so adding them to pass the scan.

Fixes #33802	CID: 220434
Fixes #33785	CID: 220451

Signed-off-by: Enjia Mai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enjiamai enjiamai

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: lib: fix coverity issues of resource leaks for mem_alloc testcase enjiamai/zephyr
3 participants
@nashif @enjiamai @zephyrbot