Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID: 220448] Out-of-bounds access in tests/subsys/modbus/src/test_modbus_raw.c #33788

Closed
zephyrbot opened this issue Mar 29, 2021 · 2 comments
Closed

[Coverity CID: 220448] Out-of-bounds access in tests/subsys/modbus/src/test_modbus_raw.c #33788

zephyrbot opened this issue Mar 29, 2021 · 2 comments
Assignees
@jfischer-no
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/169144afa1826511ee6ec3f53d590b2c0d39d3d4/tests/subsys/modbus/src/test_modbus_raw.c

Category: Memory - corruptions
Function: server_raw_cb
Component: Tests
CID: 220448

Details:

zephyr/tests/subsys/modbus/src/test_modbus_raw.c

Line 28 in 169144a

memcpy(tmp_adu.data, adu->data,

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 29, 2021
@nashif nashif assigned jfischer-no and unassigned nashif Mar 29, 2021
@dleach02 dleach02 self-assigned this Mar 30, 2021
jfischer-no added a commit to jfischer-no/zephyr that referenced this issue Apr 1, 2021
@jfischer-no
tests: modbus: fix out-of-bounds access in raw test
cc60df0 
Use right buffer length as MIN macro argument.

Fixes: zephyrproject-rtos#33788

Signed-off-by: Johann Fischer <[email protected]>
@dleach02 dleach02 removed their assignment Apr 1, 2021
@dleach02
Copy link
Member

@jfischer-no are you going to submit a PR for this?

@carlescufi
Copy link
Member

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfischer-no jfischer-no

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nashif @jfischer-no @carlescufi @zephyrbot @dleach02