Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID: 220441] Untrusted loop bound in subsys/modbus/modbus_client.c #33795

Closed
zephyrbot opened this issue Mar 29, 2021 · 0 comments
Closed

[Coverity CID: 220441] Untrusted loop bound in subsys/modbus/modbus_client.c #33795

zephyrbot opened this issue Mar 29, 2021 · 0 comments
Assignees
@jfischer-no
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/169144afa1826511ee6ec3f53d590b2c0d39d3d4/subsys/modbus/modbus_client.c

Category: Insecure data handling
Function: mbc_validate_rd_response
Component: Other
CID: 220441

Details:

zephyr/subsys/modbus/modbus_client.c

Line 135 in 169144a

for (uint16_t i = 0; i < req_qty; i++) {

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 29, 2021
jfischer-no added a commit to jfischer-no/zephyr that referenced this issue Apr 1, 2021
@jfischer-no
modbus: fix untrusted loop bound in modbus client
8ab95a0 
Use size_t type where it makes sense and
check if the buffer is large enough before it is used.

Fixes: zephyrproject-rtos#33786
Fixes: zephyrproject-rtos#33795

Signed-off-by: Johann Fischer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfischer-no jfischer-no

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfischer-no @zephyrbot