Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID: 220429] Out-of-bounds access in subsys/net/l2/ppp/ppp_l2.c #33807

Closed
zephyrbot opened this issue Mar 29, 2021 · 1 comment
Closed
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/169144afa1826511ee6ec3f53d590b2c0d39d3d4/subsys/net/l2/ppp/ppp_l2.c#L284

Category: Memory - corruptions
Function: net_ppp_carrier_on
Component: Networking
CID: 220429

Details:

if (!atomic_test_and_set_bit(&ctx->flags, PPP_CARRIER_UP)) {

278     }
279    
280     void net_ppp_carrier_on(struct net_if *iface)
281     {
282         struct ppp_context *ctx = net_if_l2_data(iface);
283    
>>>     CID 220429:  Memory - corruptions  (ARRAY_VS_SINGLETON)
>>>     Passing "&ctx->flags" to function "atomic_test_and_set_bit" which uses it as an array. This might corrupt or misinterpret adjacent memory locations.
284         if (!atomic_test_and_set_bit(&ctx->flags, PPP_CARRIER_UP)) {
285             k_work_submit(&ctx->carrier_work);
286         }
287     }
288    
289     void net_ppp_carrier_off(struct net_if *iface)

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug labels Mar 29, 2021
@galak
Copy link
Collaborator

galak commented Mar 31, 2021

Marking this as a false positive.

@galak galak closed this as completed Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants