Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID: 220414] Unused value in tests/subsys/logging/log_backend_fs/src/log_fs_test.c #33821

Closed
zephyrbot opened this issue Mar 29, 2021 · 0 comments · Fixed by #34061
Closed
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/169144afa1826511ee6ec3f53d590b2c0d39d3d4/tests/subsys/logging/log_backend_fs/src/log_fs_test.c#L204

Category: Code maintainability issues
Function: test_log_fs_files_max
Component: Tests
CID: 220414

Details:

rc = write_log_to_file(to_log, sizeof(to_log), NULL);

198    
199         /* Fill in log files over files count limit. */
200         for (i = 0;
201              i <= CONFIG_LOG_BACKEND_FS_FILE_SIZE /
202               sizeof(to_log) * (CONFIG_LOG_BACKEND_FS_FILES_LIMIT - 1);
203              i++) {
>>>     CID 220414:  Code maintainability issues  (UNUSED_VALUE)
>>>     Assigning value from "write_log_to_file(to_log, 9U, NULL)" to "rc" here, but that stored value is overwritten before it can be used.
204             rc = write_log_to_file(to_log, sizeof(to_log), NULL);
205         }
206    
207         rc = fs_opendir(&dir, CONFIG_LOG_BACKEND_FS_DIR);
208         zassert_equal(rc, 0, "Can not open directory.");
209         /* Count log files. */

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 29, 2021
@nashif nashif assigned nordic-krch and unassigned nashif Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants