Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smp_svr sample configured for serial port with shell management enabled does not work #34670

Closed
de-nordic opened this issue Apr 28, 2021 · 0 comments · Fixed by #34937
Closed

smp_svr sample configured for serial port with shell management enabled does not work #34670

de-nordic opened this issue Apr 28, 2021 · 0 comments · Fixed by #34937
Assignees
@de-nordic
Labels
area: mcumgr bug The issue is a bug, or the PR is fixing a bug

Comments

@de-nordic
Copy link
Collaborator

Describe the bug
smp_svr sample for serial with overlay-shell-mgmt.conf applied does not respond to mcumgr requests.
Tested on nrf52840dk_nrf52840

To Reproduce
Steps to reproduce the behavior:

  1. build sample for nrf52840dk_nr52840 according to instruction (https://docs.zephyrproject.org/latest/samples/subsys/mgmt/mcumgr/smp_svr/README.html?highlight=smp_svr) but with nrf52840dk_nrf52840 selected as platform
west build -b nrf52840dk_nrf52840  zephyr/samples/subsys/mgmt/mcumgr/smp_svr -t menuconfig  --  -DOVERLAY_CONFIG='overlay-serial.conf;overlay-fs.conf;overlay-shell-mgmt.conf'
  1. set BOOTLOADER_MCUBOOT option to the key of mcuboot on board.
  2. west flash --build-dir build
  3. try to connect
    sudo ~/go/bin/mcumgr -t 1200 --conntype serial --connstring dev=/dev/ttyACM0,baud=115200 image list

nothing happens

Expected behavior
List of images should appear which works when the overlay-shell-mgmt.conf is removed from above build.

Environment (please complete the following information):

Additional context
Probably some changes to shell backends have impacted passing mcumgr data to shell via uart.
@de-nordic de-nordic added bug The issue is a bug, or the PR is fixing a bug area: mcumgr labels Apr 28, 2021
@de-nordic de-nordic self-assigned this Apr 28, 2021
de-nordic added a commit to de-nordic/zephyr that referenced this issue May 6, 2021
@de-nordic
samples/subsys/mgmt/smp_svr: Fix shell mgmt not working via serial
0993c7f 
The Kconfig option SHELL_BACKEND_SERIAL had been defaulting to y,
causing shell to block mcumgr from processing serial input.

Fixes: zephyrproject-rtos#34670

Signed-off-by: Dominik Ermel <[email protected]>
@de-nordic de-nordic mentioned this issue May 6, 2021
Merged
galak pushed a commit that referenced this issue May 6, 2021
@de-nordic @galak
samples/subsys/mgmt/smp_svr: Fix shell mgmt not working via serial
56c2235 
The Kconfig option SHELL_BACKEND_SERIAL had been defaulting to y,
causing shell to block mcumgr from processing serial input.

Fixes: #34670

Signed-off-by: Dominik Ermel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-nordic de-nordic

Labels
area: mcumgr bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

samples/subsys/mgmt/smp_svr: Fix shell mgmt not working via serial de-nordic/zephyr
1 participant
@de-nordic