Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misleading root folder size in footprint reports #34978

Closed
ktaborowski opened this issue May 7, 2021 · 0 comments · Fixed by #35078
Closed

misleading root folder size in footprint reports #34978

ktaborowski opened this issue May 7, 2021 · 0 comments · Fixed by #35078
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Milestone

Comments

@ktaborowski
Copy link

Is your enhancement proposal related to a problem? Please describe.
The problem is in ram (and rom) report generated with ninja ram_report command.
It is described based on the ascii tree view, but it impacts .json report also.

The size of root folder in report is misleading, as it describes only the symbols without parent folder, but not the folders (incoherent behavior).

Path                 Size    %   
=================================
root                   40 11.76% 
├── sym1               10 2.94%  
├── sym2               10 2.94%  
├── folder1           100 29.41% 
│   └── source1.c     100 29.41% 
│       ├── item11     50 0.40%  
│       └── item12     50 2.16%  
├── sym3               10 2.94%  
├── folder2           200 58.82% 
│   └── source2.c     200 58.82% 
│       ├── item21    100 29.41% 
│       └── item22    100 29.41% 
└── sym4               10 2.94%  
=================================
                      340        

Describe the solution you'd like
I would like the report to group all "free" symbols in the generic folder (the exemplary name _unassigned used in snippet below).
The root size would be the size of all elements.

Path                 Size    %   
=================================
root                  340 100.00%   
├── folder1           100 29.41% 
│   └── source1.c     100 29.41% 
│       ├── item11     50 0.40%  
│       └── item12     50 2.16%   
├── folder2           200 58.82% 
│   └── source2.c     200 58.82% 
│       ├── item21    100 29.41% 
│       └── item22    100 29.41% 
└── _unassigned        40 11.76% 
    ├── sym1           10 2.94% 
    ├── sym2           10 2.94% 
    ├── sym3           10 2.94% 
    └── sym4           10 2.94%  
=================================
                      340        
@ktaborowski ktaborowski added the Enhancement Changes/Updates/Additions to existing features label May 7, 2021
@dcpleung dcpleung added bug The issue is a bug, or the PR is fixing a bug and removed Enhancement Changes/Updates/Additions to existing features labels May 11, 2021
@dcpleung dcpleung linked a pull request May 11, 2021 that will close this issue
@galak galak added this to the v2.6.0 milestone May 11, 2021
@galak galak added the priority: low Low impact/importance bug label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants