Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID: 220616] Arguments in wrong order in tests/subsys/canbus/isotp/conformance/src/main.c #35110

Closed
zephyrbot opened this issue May 11, 2021 · 1 comment
Closed

[Coverity CID: 220616] Arguments in wrong order in tests/subsys/canbus/isotp/conformance/src/main.c #35110

zephyrbot opened this issue May 11, 2021 · 1 comment
Assignees
@alexanderwachter
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Milestone
v2.6.0

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/0622bde3bf22926544c1aaef4c01dfa23d79f26e/tests/subsys/canbus/isotp/conformance/src/main.c

Category: API usage errors
Function: test_send_sf_fixed
Component: Tests
CID: 220616

Details:

zephyr/tests/subsys/canbus/isotp/conformance/src/main.c

Line 453 in 0622bde

ret = isotp_send(&send_ctx, can_dev, random_data, DATA_SIZE_SF,

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels May 11, 2021
@nashif nashif assigned alexanderwachter and unassigned nashif May 11, 2021
@galak galak added this to the v2.6.0 milestone May 11, 2021
galak added a commit to galak/zephyr that referenced this issue May 13, 2021
@galak
tests: canbus: conformance: Fix arg passing order
2146acd 
The order of arguments passed to isotp_send was swapped for the
rx and tx buffers.

Fixes zephyrproject-rtos#35110

Signed-off-by: Kumar Gala <[email protected]>
@galak galak mentioned this issue May 13, 2021
Closed
@galak
Copy link
Collaborator

galak commented May 13, 2021

The args are meant to be swapped, so this is not an issue.

@galak galak closed this as completed May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderwachter alexanderwachter

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

tests: canbus: conformance: Fix arg passing order galak/zephyr
4 participants
@nashif @alexanderwachter @galak @zephyrbot