Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID: 235932] Logically dead code in samples/sensor/adxl372/src/main.c #35119

Closed
zephyrbot opened this issue May 11, 2021 · 0 comments · Fixed by #35192
Closed

[Coverity CID: 235932] Logically dead code in samples/sensor/adxl372/src/main.c #35119

zephyrbot opened this issue May 11, 2021 · 0 comments · Fixed by #35192
Assignees
@MaureenHelm
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Milestone
v2.6.0

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/0622bde3bf22926544c1aaef4c01dfa23d79f26e/samples/sensor/adxl372/src/main.c

Category: Control flow issues
Function: main
Component: Samples
CID: 235932

Details:

zephyr/samples/sensor/adxl372/src/main.c

Line 54 in 0622bde

printf("Devicetree has no adi,adxl372 node\n");

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels May 11, 2021
@galak galak added this to the v2.6.0 milestone May 11, 2021
@MaureenHelm MaureenHelm mentioned this issue May 12, 2021
Merged
galak pushed a commit that referenced this issue May 12, 2021
@MaureenHelm @galak
samples: sensor: Fix logically dead code in adxl372 sample
53f21e1 
Converts the adxl372 sample application to check the sensor device at
build time instead of runtime. This fixes a Coverity issue for logically
dead code introduced in commit 72795c3.

Fixes #35119
Coverity-CID: 235932

Signed-off-by: Maureen Helm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaureenHelm MaureenHelm

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

samples: sensor: Fix logically dead code in adxl372 and bmg160 samples nxp-zephyr/zephyr
3 participants
@MaureenHelm @galak @zephyrbot