Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID: 236003] Logically dead code in subsys/bluetooth/audio/vcs.c #35132

Closed
zephyrbot opened this issue May 11, 2021 · 0 comments · Fixed by #35394
Closed

[Coverity CID: 236003] Logically dead code in subsys/bluetooth/audio/vcs.c #35132

zephyrbot opened this issue May 11, 2021 · 0 comments · Fixed by #35394
Assignees
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Milestone

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/0622bde3bf22926544c1aaef4c01dfa23d79f26e/subsys/bluetooth/audio/vcs.c#L530

Category: Control flow issues
Function: bt_vcs_vol_down
Component: Bluetooth
CID: 236003

Details:

return -EOPNOTSUPP;

524              int err = write_vcs_control(NULL, NULL, &cp, sizeof(cp), 0, 0);
525     
526              return err > 0 ? 0 : err;
527      }
528     #endif /* CONFIG_BT_VCS */
529     
>>>     CID 236003:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "return -95;".
530      return -EOPNOTSUPP;
531     }
532     
533     int bt_vcs_vol_up(struct bt_conn *conn)
534     {
535     #if defined(CONFIG_BT_VCS_CLIENT)

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels May 11, 2021
@galak galak added this to the v2.6.0 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants