[Coverity CID: 236085] Dereference after null check in samples/userspace/prod_consumer/src/app_a.c

[zephyrbot]

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/21d1ad3762302b3e461953df59430c77e0709274/samples/userspace/prod_consumer/src/app_a.c#L222

Category: Null pointer dereferences
Function: app_a_entry
Component: Samples
CID: 236085

Details:

zephyr/samples/userspace/prod_consumer/src/app_a.c

Line 222 in 21d1ad3

sample_driver_set_callback(sample_device, sample_callback, NULL);

216      k_thread_heap_assign(k_current_get(), &app_a_resource_pool);
217     
218      /* Set the callback function for the sample driver. This has to be
219       * done from supervisor mode, as this code will run in supervisor
220       * mode in IRQ context.
221       */
>>>     CID 236085:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "sample_device" to "sample_driver_set_callback", which dereferences it.
222      sample_driver_set_callback(sample_device, sample_callback, NULL);
223     
224      /* Set up the writeback thread, which takes processed data from
225       * application B and sends it to the sample device.
226       *
227       * This child thread automatically inherits the memory domain of

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

[dcpleung]

There is a call to k_oops() above if sample_device == NULL, so it won't be NULL when passed to sample_driver_set_callback(). So ignore.