Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID: 236074] Out-of-bounds access in tests/lib/c_lib/src/main.c #35345

Closed
zephyrbot opened this issue May 17, 2021 · 0 comments · Fixed by #35425
Closed

[Coverity CID: 236074] Out-of-bounds access in tests/lib/c_lib/src/main.c #35345

zephyrbot opened this issue May 17, 2021 · 0 comments · Fixed by #35425
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https:/zephyrproject-rtos/zephyr/tree/21d1ad3762302b3e461953df59430c77e0709274/tests/lib/c_lib/src/main.c#L557

Category: Memory - corruptions
Function: test_memcpy
Component: Tests
CID: 236074

Details:

zassert_equal(memcpy(mem_dest_tmp, mem_src_tmp, 10),

551     
552      /* restore the environment */
553      memset(mem_dest_byte, '\0', sizeof(mem_dest));
554      /* verify when dest and src are all in not word aligned */
555      mem_dest_tmp = mem_dest_byte + sizeof(uintptr_t) - 1;
556      mem_src_tmp = mem_src_byte + sizeof(uintptr_t) - 1;
>>>     CID 236074:  Memory - corruptions  (OVERRUN)
>>>     Overrunning buffer pointed to by "mem_dest_tmp" of 12 bytes by passing it to a function which accesses it at byte offset 12 using argument "10U". [Note: The source code implementation of the function has been overridden by a builtin model.]
557      zassert_equal(memcpy(mem_dest_tmp, mem_src_tmp, 10),
558              mem_dest_tmp, "memcpy error");
559      zassert_equal(memcmp(mem_dest_tmp, mem_src_tmp, 10),
560              0, "memcpy failed");
561     
562      /* restore the environment */

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels May 17, 2021
@yingmingx yingmingx assigned yingmingx and unassigned nashif May 19, 2021
yingmingx pushed a commit to yingmingx/zephyr that referenced this issue May 19, 2021
The coverity report "Out-of-bounds access". The reason is
The room of src and dest buffer is less than the count wanted
to be copyied. So enlarged the src and dest buffer to solve this
issue.

Fixes:zephyrproject-rtos#35345
Fixes:zephyrproject-rtos#35346

Signed-off-by: Ying ming <[email protected]>
galak pushed a commit that referenced this issue May 19, 2021
The coverity report "Out-of-bounds access". The reason is
The room of src and dest buffer is less than the count wanted
to be copyied. So enlarged the src and dest buffer to solve this
issue.

Fixes:#35345
Fixes:#35346

Signed-off-by: Ying ming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants