Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all menuconfig interfaces contain sound open firmware/SOF text #35553

Closed
mbolivar-nordic opened this issue May 21, 2021 · 0 comments · Fixed by #35559
Closed

all menuconfig interfaces contain sound open firmware/SOF text #35553

mbolivar-nordic opened this issue May 21, 2021 · 0 comments · Fixed by #35559
Assignees
@nashif
Labels
bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Milestone
v2.6.0

Comments

@mbolivar-nordic
Copy link
Contributor

mbolivar-nordic commented May 21, 2021 •
edited
Loading

Describe the bug

The SOF mainmenu here is affecting all zephyr applications:

https:/zephyrproject-rtos/sof/blob/52dc9c5ad8d0d2a5df0bb51ea30e54f8d7890639/Kconfig#L3

It should be removed.

To Reproduce

west build -b native_posix -t menuconfig -p -s samples/hello_world/

The "SOF Configuration" banner appears at the top:

2021-05-21T10:43:58,928935584-07:00

Expected behavior

No SOF specifics here
@mbolivar-nordic mbolivar-nordic added the bug The issue is a bug, or the PR is fixing a bug label May 21, 2021
@mbolivar-nordic mbolivar-nordic added this to the v2.6.0 milestone May 21, 2021
@nashif nashif added the priority: high High impact/importance bug label May 22, 2021
@nashif nashif mentioned this issue May 22, 2021
Merged
nashif added a commit to nashif/zephyr that referenced this issue May 24, 2021
@nashif
sof: do not get mainmenu from SOF project
30f933a 
Do not get the mainmenu title from SOF by splitting Kconfig the same way
we do it in Zephyr.

Fixes zephyrproject-rtos#35553

Signed-off-by: Anas Nashif <[email protected]>
galak pushed a commit that referenced this issue May 24, 2021
@nashif @galak
sof: do not get mainmenu from SOF project
3b19598 
Do not get the mainmenu title from SOF by splitting Kconfig the same way
we do it in Zephyr.

Fixes #35553

Signed-off-by: Anas Nashif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nashif nashif

Labels
bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

sof: do not get mainmenu from SOF project nashif/zephyr
2 participants
@nashif @mbolivar-nordic