Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: can: mcan: sjw not initialized when CAN_FD_MODE is enabled #35737

Closed
str4t0m opened this issue May 27, 2021 · 1 comment · Fixed by #35738
Closed

drivers: can: mcan: sjw not initialized when CAN_FD_MODE is enabled #35737

str4t0m opened this issue May 27, 2021 · 1 comment · Fixed by #35738
Assignees
Labels
area: CAN bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@str4t0m
Copy link
Collaborator

str4t0m commented May 27, 2021

Describe the bug
The mcan driver does not initialize the timing.sjw variable in CAN_FD_MODE configuration.
This causes undefined behavior and might trigger a assert that checks the valid range of this parameter.

Expected behavior
The synchronization jump width should be initialized with the parameter configured.

Impact
Undefined behavior might lead to synchronization problems.

@str4t0m str4t0m added the bug The issue is a bug, or the PR is fixing a bug label May 27, 2021
@alexanderwachter alexanderwachter self-assigned this May 27, 2021
@alexanderwachter
Copy link
Member

Fix: #35738

@galak galak added the priority: low Low impact/importance bug label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CAN bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants