Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: controller: Fix assert on peer unknown rsp #1390

Merged

Conversation

cvinayak
Copy link
Contributor

@cvinayak cvinayak commented Sep 7, 2017

Fixed an assert when peer responded with unknown rsp to
slave feature request when an existing another control
procedure was in progress.

This assert happened with a BT v4.0 peer implementation that
was performing a channel map update and local controller
initiated a slave feature request, receiving an unknown
response.

Signed-off-by: Vinayak Kariappa Chettimada [email protected]

Fixed an assert when peer responded with unknown rsp to
slave feature request when an existing another control
procedure was in progress.

This assert happened with a BT v4.0 peer implementation that
was performing a channel map update and local controller
initiated a slave feature request, receiving an unknown
response.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N/A

@carlescufi carlescufi added the bug The issue is a bug, or the PR is fixing a bug label Sep 7, 2017
@carlescufi carlescufi added this to the v1.9 milestone Sep 7, 2017
Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my previous comment, I looked at the wrong patch

@Laczen
Copy link
Collaborator

Laczen commented Sep 7, 2017

Hi,

I can confirm that this solved the Hard Fault I reported to the developers mailing list.

Kind regards,

Jehudi

Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified by reporter

@carlescufi
Copy link
Member

@Laczen Thank you for the bug report and verification

@jhedberg jhedberg requested a review from nashif September 7, 2017 09:23
@nashif nashif merged commit f43e4e0 into zephyrproject-rtos:master Sep 7, 2017
@cvinayak cvinayak deleted the github_unsupp_slave_feat_req_fix branch September 14, 2017 19:00
@nashif nashif modified the milestones: v1.9, v1.9.0 Oct 3, 2017
nagineni pushed a commit to nagineni/zephyr that referenced this pull request Nov 20, 2017
Linux instance can now be closed from JS with process.exit()

Fixes zephyrproject-rtos#1387

Signed-off-by: James Prestwood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants