samples: net: azure: Avoid negative array index write #27192
Conversation
If the mqtt_read_publish_payload() returns <0 value, then do not use that value when accessing the data array. Fixes: zephyrproject-rtos#25775 Coverity-CID: 210075 Signed-off-by: Jukka Rissanen <[email protected]>
| @@ -249,8 +249,9 @@ static void mqtt_event_handler(struct mqtt_client *const client, | |||
| data, | |||
| len >= sizeof(data) - 1 ? | |||
| sizeof(data) - 1 : len); | |||
| if (bytes_read < 0 && bytes_read != -EAGAIN) { | |||
| LOG_ERR("failure to read payload"); | |||
| if (bytes_read < 0) { | |||
There was a problem hiding this comment.
I think mqtt_read_publish_payload_blocking should be used here instead. mqtt_read_publish_payload is non-blocking function, so returning -EAGAIN is not really an error (but the design of this loop isn't great since it'll keep spinning in that case apart from the issue detected by coverity). With the blocking function, it should be safe to abort on any error.
There was a problem hiding this comment.
That sounds better indeed. I am not able to test these kind of changes right now so need to postpone this PR a bit.
|
Can we pick this back up? It will help with the release metrics. |
I am not able to work on this right now, but I do not object if someone is able to. |
jenmwms
added
bug
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
@rlubos do you have the means to test this patch? Otherwise I suggest we accept the fix. |
Currently not, my Azure trial has expired. |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
If the mqtt_read_publish_payload() returns <0 value, then do
not use that value when accessing the data array.
Fixes: #25775
Coverity-CID: 210075
Signed-off-by: Jukka Rissanen [email protected]