IPv6 fragmentation fixes #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous default 60 seconds is way too long for our limited amount of memory. It might be that the 5 sec is still too long but that can be changed in the future. Signed-off-by: Jukka Rissanen <[email protected]>
If the fragmented IPv6 packet was very large, we could run out of resources. When that happened, we leaked the memory for the pending fragments that were waiting reassembly. Jira: ZEP-2166 Signed-off-by: Jukka Rissanen <[email protected]>
tbursztyka
approved these changes
May 29, 2017
tbursztyka
approved these changes
May 29, 2017
tbursztyka
approved these changes
May 29, 2017
tbursztyka
reviewed
May 29, 2017
subsys/net/ip/ipv6.c
Outdated
| * in the packet. There cannot be any extensions after the normal or | ||
| * typical IP protocols | ||
| */ | ||
| switch (next) { |
tbursztyka
previously approved these changes
May 29, 2017
The IPv6 fragmentation was not working properly when the large IPv6 packet was being sent. There is unit tests in next commit that will test the IPv6 fragmentation sending. Signed-off-by: Jukka Rissanen <[email protected]>
The cancellation of reassembly did not work as expected because K_WORK_INITIALIZER() did not setup the timeout function properly. So do the timer initialization at runtime instead. Signed-off-by: Jukka Rissanen <[email protected]>
If the user really wants, it is possible to increase the maximum size of the fragmented packet. According to RFC 2460 chapter 5, we do not need to accept larger than 1500 byte IPv6 packets, so the max pkt limit is set to 2. But if really needed the limit can be raised by defining NET_IPV6_FRAGMENTS_MAX_PKT to some new value. Currently there is no Kconfig option for doing this as it is unlikely that this is needed. Signed-off-by: Jukka Rissanen <[email protected]>
These tests make sure that the IPv6 fragments are build correctly when a large IPv6 packet is being sent. Signed-off-by: Jukka Rissanen <[email protected]>
Print also network buffers that are allocated by the IPv6 fragment handler. This is very useful in debugging. Signed-off-by: Jukka Rissanen <[email protected]>
|
Changed the switch() to if() in patch 3. |
tbursztyka
approved these changes
May 30, 2017
This was referenced Sep 18, 2017
nagineni
pushed a commit
to nagineni/zephyr
that referenced
this pull request
Nov 20, 2017
…ct-rtos#289) Signed-off-by: James Prestwood <[email protected]>
parthitce
pushed a commit
to linumiz/zephyr
that referenced
this pull request
Jun 21, 2023
bugfix: floating point representaion without fractional part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.