-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
board: arm: add support for the teensy4 board #32285
Conversation
a58fbe0
to
8568765
Compare
60a4b94
to
48e1fc4
Compare
Had to remove the config file for spi loopback test, caused errors in the tests. |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your contribution, and apologies for the late review.
I'm not sure how to handle the alternative ethernet PHY yet, because the hal_nxp repo is for code imported from the MCUXpresso SDK. New code developed for zephyr should go into the main zephyr repo.
boards/arm/teensy4/Kconfig.board
Outdated
# correct part no would be MIMXRT1062DVJ6A for TEENSY41, but this type does | ||
# not exist in zephyr´s SOC definition. MIMXRT1062DVL6A type is used instead | ||
# as the only difference is package pitch. | ||
select SOC_PART_NUMBER_MIMXRT1062DVL6A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go ahead and add this part number to soc/arm/nxp_imx/rt/Kconfig.soc
The #34718 is proposing a generic PHY and MDIO driver. Could that PR utilized with this PR and mcux driver? |
@jukkar Thanks for your advise, I will try. Using a generic driver would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better, thank you!
Will you please split the PHY and SOC_PART_NUMBER_MIMXRT1062DVJ6A
changes into separate commits?
98cc904
to
5fb53fe
Compare
MIMXRT1062DVJ6A Signed-off-by: Bernhard Krämer <[email protected]>
Current solution provides a workaround for the ethernet phy without needing zephyrproject-rtos/hal_nxp#71. Since this is a rather hacky solution, I would agree to rework to generic Phy driver as soon as #34718 is accepted. |
I'm interested in getting this merged, is there anything I can do to assist with this. I have a 4.0 and a 4.1 so I can do some testing (with the sdcard for example, etc), or I can take a stab at any refactoring that needs to be done. |
The provided networking solution prevents this PR from being merged. Last weeks I hoped that #34718 will soon be accepted and also prepared a new networking solution based on this. But this seems to get a longer story and also deeply affects the mcux ethernet stack, which will make the things complicated. So I will rewrite this PR next days and remove networking for the moment. @ld-cd |
Alright, I'll do some testing with the SDCard and see if I encounter anything that can be improved |
supports version 4.0 and 4.1 Signed-off-by: Bernhard Krämer <[email protected]>
@dleach02 will you please review? |
@bdkrae looks like there are some CI failures on these boards:
|
This branch adds support for the teensy4 board family (Teensy 4.0 and Teensy 4.1). The configuration is based on the mimxrt1060_evk, the teensy project documentation and the IMXRT1060 reference manual.
Code is successfully tested with the following sample code:
blinky
philosophers
hello_world
drivers/can
Zephyr spi loopback test also succeeds, config file is included in this PR.
Example applications using many peripherals can be found here:
https:/ufechner7/zephyr_teensy4_test
https:/bdkrae/zephyr_teensy4_test
Closes #30204.